Android pushes went through Commet's push gateway (push.commet.chat) by default #42

New issue

Open

opened 2026-10-05 19:22:51 +00:00 by robocub · 0 comments

robocub commented

2026-10-05 19:22:51 +00:00

Owner

Fork-only bug (upstream intends to use its own gateway, so there's nothing to check upstream).

The UnifiedPush build registered its Matrix pushers with push.commet.chat, Commet's push gateway. The choice had been removed from the Settings › Notifications dropdown, but the default in config/preferences.dart (pushGateway, used when no gateway was ever saved) still pointed there. So every Vommet Android user's push notifications went through Commet's infrastructure, against the fork's rule of not using Commet's services.

Fix: branch fix/own-push-gateway. The default becomes matrix.gateway.unifiedpush.org, the UnifiedPush project's public Matrix gateway. updatePushers() deletes pushers whose gateway URL differs and registers a new one, so existing installs migrate on their next start.

Follow-ups:

UnifiedPush recommends discovering the gateway from the distributor itself. ntfy and others answer GET <endpoint host>/_matrix/push/v1/notify with {"unifiedpush":{"gateway":"matrix"}}, which avoids any third-party gateway. Prefer that, falling back to the public gateway.
Possibly related to #41 (notifications failing in the background); retest #41 after this lands.
A CI check that fails on new references to Commet's hosts (*.commet.chat) is being added with the upstream-sync tooling, so an upstream change can't silently reintroduce one.

Fork-only bug (upstream intends to use its own gateway, so there's nothing to check upstream). The UnifiedPush build registered its Matrix pushers with **`push.commet.chat`**, Commet's push gateway. The choice had been removed from the Settings › Notifications dropdown, but the default in `config/preferences.dart` (`pushGateway`, used when no gateway was ever saved) still pointed there. So every Vommet Android user's push notifications went through Commet's infrastructure, against the fork's rule of not using Commet's services. **Fix:** branch `fix/own-push-gateway`. The default becomes `matrix.gateway.unifiedpush.org`, the UnifiedPush project's public Matrix gateway. `updatePushers()` deletes pushers whose gateway URL differs and registers a new one, so existing installs migrate on their next start. **Follow-ups:** - UnifiedPush recommends discovering the gateway from the distributor itself. ntfy and others answer `GET <endpoint host>/_matrix/push/v1/notify` with `{"unifiedpush":{"gateway":"matrix"}}`, which avoids any third-party gateway. Prefer that, falling back to the public gateway. - Possibly related to #41 (notifications failing in the background); retest #41 after this lands. - A CI check that fails on new references to Commet's hosts (`*.commet.chat`) is being added with the upstream-sync tooling, so an upstream change can't silently reintroduce one.

robocub added the

bug

infra

effort: small

labels

2026-10-05 19:22:51 +00:00

robocub referenced this issue from a commit

2026-10-05 19:25:11 +00:00

ci: fail on unlisted references to Commet's hosts

robocub referenced this issue from a commit

2026-10-05 20:20:01 +00:00

ci: fail on unlisted references to Commet's hosts