Per-room banners #6

New issue

Open

opened 2026-10-04 20:18:48 +00:00 by robocub · 1 comment

robocub commented

2026-10-04 20:18:48 +00:00

Owner

Why

Discord servers and channels feel like places partly because of their banners. Commet already shows banners for spaces; rooms are the gap.

What exists

MatrixSpaceBannerComponent (commet/lib/client/matrix/components/space_banner/) reads and writes the state event page.codeberg.everypizza.room.banner, so space banners already interoperate with other clients that use that event.
It is registered for spaces only (component_registry.dart, around line 101).
Room creation already gives that event a power level (matrix_client.dart, around line 353).

Plan

Generalise the component (or add a room twin) so rooms get the same read/write behaviour with the same event type.
Show the banner at the top of the room info / member panel, and optionally a slim strip in the room header; keep it out of the timeline.
Edit button gated on the power level for that event, with the existing image cropper.
Respect the existing "don't auto-play animated media" preferences for animated banners.

Acceptance

Set a banner on a room in the fork; it shows for every member using the fork, and the raw state event matches what spaces use.

Filed with LLM assistance. This is a fork-only issue; never refile it on Commet's tracker.

## Why Discord servers and channels feel like places partly because of their banners. Commet already shows banners for spaces; rooms are the gap. ## What exists - `MatrixSpaceBannerComponent` (`commet/lib/client/matrix/components/space_banner/`) reads and writes the state event `page.codeberg.everypizza.room.banner`, so space banners already interoperate with other clients that use that event. - It is registered for spaces only (`component_registry.dart`, around line 101). - Room creation already gives that event a power level (`matrix_client.dart`, around line 353). ## Plan - Generalise the component (or add a room twin) so rooms get the same read/write behaviour with the same event type. - Show the banner at the top of the room info / member panel, and optionally a slim strip in the room header; keep it out of the timeline. - Edit button gated on the power level for that event, with the existing image cropper. - Respect the existing "don't auto-play animated media" preferences for animated banners. ## Acceptance Set a banner on a room in the fork; it shows for every member using the fork, and the raw state event matches what spaces use. --- _Filed with LLM assistance. This is a fork-only issue; never refile it on Commet's tracker._

robocub added the

feature

effort: small

labels

2026-10-04 20:18:48 +00:00

robocub referenced this issue from a commit

2026-10-04 21:26:36 +00:00

feat: per-room banners (#6)

robocub commented

2026-10-04 23:31:53 +00:00

Author

Owner

Implemented on branch feat/room-banners (0bc6283), CI green, not merged. Same state event as space banners. Editor under room settings > Appearance (only for members allowed to change it); banner strip at the top of the room side panel; live updates when anyone changes it. Not done: a header strip, and the animated-media preference for animated banners. Needs a hands-on check before merging.

Filed with LLM assistance.

Implemented on branch `feat/room-banners` (0bc6283), CI green, not merged. Same state event as space banners. Editor under room settings > Appearance (only for members allowed to change it); banner strip at the top of the room side panel; live updates when anyone changes it. Not done: a header strip, and the animated-media preference for animated banners. Needs a hands-on check before merging. --- _Filed with LLM assistance._

robocub referenced this issue from a commit

2026-10-05 20:20:09 +00:00

feat: per-room banners (#6)

robocub referenced this issue

2026-10-05 21:03:22 +00:00

Automated testing roadmap #46